Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b81fadd authored by JaeMan Park's avatar JaeMan Park Committed by Pavel Machek
Browse files

mac80211_hwsim: initialize ieee80211_tx_info at hw_scan_work 



[ Upstream commit cacfddf82baf1470e5741edeecb187260868f195 ]

In mac80211_hwsim, the probe_req frame is created and sent while
scanning. It is sent with ieee80211_tx_info which is not initialized.
Uninitialized ieee80211_tx_info can cause problems when using
mac80211_hwsim with wmediumd. wmediumd checks the tx_rates field of
ieee80211_tx_info and doesn't relay probe_req frame to other clients
even if it is a broadcasting message.

Call ieee80211_tx_prepare_skb() to initialize ieee80211_tx_info for
the probe_req that is created by hw_scan_work in mac80211_hwsim.

Signed-off-by: default avatarJaeMan Park <jaeman@google.com>
Link: https://lore.kernel.org/r/20220113060235.546107-1-jaeman@google.com


[fix memory leak]
Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
parent b2e15370

drivers/net/wireless/mac80211_hwsim.c

+9 −0
Original line number Diff line number Diff line
@@ -1899,6 +1899,15 @@ static void hw_scan_work(struct work_struct *work) 
				memcpy(skb_put(probe, req->ie_len), req->ie,

				       req->ie_len);



			if (!ieee80211_tx_prepare_skb(hwsim->hw,

						      hwsim->hw_scan_vif,

						      probe,

						      hwsim->tmp_chan->band,

						      NULL)) {

				kfree_skb(probe);

				continue;

			}



			local_bh_disable();

			mac80211_hwsim_tx_frame(hwsim->hw, probe,

						hwsim->tmp_chan);