Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7b3433c6 authored by Venkat Gopalakrishnan's avatar Venkat Gopalakrishnan
Browse files

scsi: ufs: validate input args to queuecommand 



Make sure to validate the input args to queuecommand to avoid
NULL dereferences.

Change-Id: I803e1cc019a4c5569fed9ee08113e323daab75c8
Signed-off-by: default avatarVenkat Gopalakrishnan <venkatg@codeaurora.org>
parent 314869eb

drivers/scsi/ufs/ufshcd.c

+9 −7
Original line number Diff line number Diff line
@@ -2769,6 +2769,9 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 


	hba = shost_priv(host);



	if (!cmd || !cmd->request || !hba)

		return -EINVAL;



	tag = cmd->request->tag;

	if (!ufshcd_valid_tag(hba, tag)) {

		dev_err(hba->dev,
@@ -2854,12 +2857,11 @@ static int ufshcd_queuecommand(struct Scsi_Host *host, struct scsi_cmnd *cmd) 
	ufshcd_vops_pm_qos_req_start(hba, cmd->request);



	/* IO svc time latency histogram */

	if (hba != NULL && cmd->request != NULL) {

	if (hba->latency_hist_enabled &&

	    (cmd->request->cmd_type == REQ_TYPE_FS)) {

		cmd->request->lat_hist_io_start = ktime_get();

		cmd->request->lat_hist_enabled = 1;

		} else

	} else {

		cmd->request->lat_hist_enabled = 0;

	}