Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7967865b authored by E V Ravi's avatar E V Ravi Committed by Gerrit - the friendly Code Review server
Browse files

msm: ais: sensor: actuator: fix out of bound read for bivcm region params 



Issue:
The region index for bivcm is not validated against the region size.
This cause out-of-bound read on the KASAN kernel.
Fix:
Add restriction that region index smaller than region size.
CRs-Fixed: 2379514

Change-Id: Iff77993000fc89513be90d9de174728fed3b50a7
Signed-off-by: default avatarE V Ravi <evenka@codeaurora.org>
parent 291c54b2

drivers/media/platform/msm/ais/sensor/actuator/msm_actuator.c

+3 −1
Original line number Diff line number Diff line 
/* Copyright (c) 2011-2018, The Linux Foundation. All rights reserved.

/* Copyright (c) 2011-2019, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -768,6 +768,8 @@ static int32_t msm_actuator_bivcm_move_focus( 
		a_ctrl->curr_step_pos, dest_step_pos, curr_lens_pos);



	while (a_ctrl->curr_step_pos != dest_step_pos) {

		if (a_ctrl->curr_region_index >= a_ctrl->region_size)

			break;

		step_boundary =

			a_ctrl->region_params[a_ctrl->curr_region_index].

			step_bound[dir];