Commit 792f1fe5 authored Jun 29, 2017 by Thomas Gleixner Committed by Greg Kroah-Hartman Aug 16, 2017

pinctrl: samsung: Remove bogus irq_[un]mask from resource management



commit 3fa53ec2ed885b0aec3f0472e3b4a8a6f1cd748c upstream.

The irq chip callbacks irq_request/release_resources() have absolutely no
business with masking and unmasking the irq.

The core code unmasks the interrupt after complete setup and masks it
before invoking irq_release_resources().

The unmask is actually harmful as it happens before the interrupt is
completely initialized in __setup_irq().

Remove it.

Fixes: f6a8249f ("pinctrl: exynos: Lock GPIOs as interrupts when used as EINTs")
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Kukjin Kim <kgene@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
Acked-by: Tomasz Figa <tomasz.figa@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6f51066b

drivers/pinctrl/samsung/pinctrl-exynos.c

+0 −4

Original line number	Original line	Diff line number	Diff line
	@@ -194,8 +194,6 @@ static int exynos_irq_request_resources(struct irq_data *irqd)

	spin_unlock_irqrestore(&bank->slock, flags);		spin_unlock_irqrestore(&bank->slock, flags);

	exynos_irq_unmask(irqd);

	return 0;		return 0;
	}		}

	@@ -216,8 +214,6 @@ static void exynos_irq_release_resources(struct irq_data *irqd)
	shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];		shift = irqd->hwirq * bank_type->fld_width[PINCFG_TYPE_FUNC];
	mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;		mask = (1 << bank_type->fld_width[PINCFG_TYPE_FUNC]) - 1;

	exynos_irq_mask(irqd);

	spin_lock_irqsave(&bank->slock, flags);		spin_lock_irqsave(&bank->slock, flags);

	con = readl(d->virt_base + reg_con);		con = readl(d->virt_base + reg_con);