Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 780e559a authored by Stefan Wahren's avatar Stefan Wahren Committed by Greg Kroah-Hartman
Browse files

net: qca_spi: Fix log level if probe fails 



[ Upstream commit 50973993260a6934f0a00da53d9b746cfbea89ab ]

In cases the probing fails the log level of the messages should
be an error.

Signed-off-by: default avatarStefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarSasha Levin <alexander.levin@microsoft.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e77b1523

drivers/net/ethernet/qualcomm/qca_spi.c

+8 −8
Original line number Diff line number Diff line
@@ -868,21 +868,21 @@ qca_spi_probe(struct spi_device *spi) 


	if ((qcaspi_clkspeed < QCASPI_CLK_SPEED_MIN) ||

	    (qcaspi_clkspeed > QCASPI_CLK_SPEED_MAX)) {

		dev_info(&spi->dev, "Invalid clkspeed: %d\n",

		dev_err(&spi->dev, "Invalid clkspeed: %d\n",

			qcaspi_clkspeed);

		return -EINVAL;

	}



	if ((qcaspi_burst_len < QCASPI_BURST_LEN_MIN) ||

	    (qcaspi_burst_len > QCASPI_BURST_LEN_MAX)) {

		dev_info(&spi->dev, "Invalid burst len: %d\n",

		dev_err(&spi->dev, "Invalid burst len: %d\n",

			qcaspi_burst_len);

		return -EINVAL;

	}



	if ((qcaspi_pluggable < QCASPI_PLUGGABLE_MIN) ||

	    (qcaspi_pluggable > QCASPI_PLUGGABLE_MAX)) {

		dev_info(&spi->dev, "Invalid pluggable: %d\n",

		dev_err(&spi->dev, "Invalid pluggable: %d\n",

			qcaspi_pluggable);

		return -EINVAL;

	}
@@ -944,7 +944,7 @@ qca_spi_probe(struct spi_device *spi) 
	}



	if (register_netdev(qcaspi_devs)) {

		dev_info(&spi->dev, "Unable to register net device %s\n",

		dev_err(&spi->dev, "Unable to register net device %s\n",

			qcaspi_devs->name);

		free_netdev(qcaspi_devs);

		return -EFAULT;