Commit 75d14ede authored Oct 11, 2010 by Jason Wessel

kdb: Fix oops in kdb_unregister



Nothing should try to use kdb_commands directly as sometimes it is
null.  Instead, use the for_each_kdbcmd() iterator.

This particular problem dates back to the initial kdb merge (2.6.35),
but at that point nothing was dynamically unregistering commands from
the kdb shell.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent e3bda3ac

kernel/debug/kdb/kdb_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2826,7 +2826,7 @@ int kdb_unregister(char *cmd)
		/*
		* find the command.
		*/
		for (i = 0, kp = kdb_commands; i < kdb_max_commands; i++, kp++) {
		for_each_kdbcmd(kp, i) {
		if (kp->cmd_name && (strcmp(kp->cmd_name, cmd) == 0)) {
		kp->cmd_name = NULL;
		return 0;