Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 754b7b63 authored by Andi Kleen's avatar Andi Kleen Committed by Linus Torvalds
Browse files

sections: disable const sections for PA-RISC v2 



The PA-RISC tool chain seems to have some problem with correct
read/write attributes on sections.  This causes problems when the const
sections are fixed up for other architecture to only contain truly
read-only data.

Disable const sections for PA-RISC

This can cause a bit of noise with modpost.

Signed-off-by: default avatarAndi Kleen <ak@linux.intel.com>
Cc: "James E.J. Bottomley" <jejb@parisc-linux.org>
Cc: Helge Deller <deller@gmx.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 0f6d93aa

arch/parisc/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -13,6 +13,7 @@ config PARISC 
	select HAVE_PERF_EVENTS

	select GENERIC_ATOMIC64 if !64BIT

	select HAVE_GENERIC_HARDIRQS

	select BROKEN_RODATA

	select GENERIC_IRQ_PROBE

	select GENERIC_PCI_IOMAP

	select IRQ_PER_CPU

include/linux/init.h

+19 −8
Original line number Diff line number Diff line
@@ -43,10 +43,21 @@ 
   discard it in modules) */

#define __init		__section(.init.text) __cold notrace

#define __initdata	__section(.init.data)

#define __initconst	__section(.init.rodata)

#define __initconst	__constsection(.init.rodata)

#define __exitdata	__section(.exit.data)

#define __exit_call	__used __section(.exitcall.exit)



/*

 * Some architecture have tool chains which do not handle rodata attributes

 * correctly. For those disable special sections for const, so that other

 * architectures can annotate correctly.

 */

#ifdef CONFIG_BROKEN_RODATA

#define __constsection(x)

#else

#define __constsection(x) __section(x)

#endif



/*

 * modpost check for section mismatches during the kernel build.

 * A section mismatch happens when there are references from a
@@ -66,7 +77,7 @@ 
 */

#define __ref            __section(.ref.text) noinline

#define __refdata        __section(.ref.data)

#define __refconst       __section(.ref.rodata)

#define __refconst       __constsection(.ref.rodata)



/* compatibility defines */

#define __init_refok     __ref
@@ -85,26 +96,26 @@ 
/* Used for HOTPLUG */

#define __devinit        __section(.devinit.text) __cold notrace

#define __devinitdata    __section(.devinit.data)

#define __devinitconst   __section(.devinit.rodata)

#define __devinitconst   __constsection(.devinit.rodata)

#define __devexit        __section(.devexit.text) __exitused __cold notrace

#define __devexitdata    __section(.devexit.data)

#define __devexitconst   __section(.devexit.rodata)

#define __devexitconst   __constsection(.devexit.rodata)



/* Used for HOTPLUG_CPU */

#define __cpuinit        __section(.cpuinit.text) __cold notrace

#define __cpuinitdata    __section(.cpuinit.data)

#define __cpuinitconst   __section(.cpuinit.rodata)

#define __cpuinitconst   __constsection(.cpuinit.rodata)

#define __cpuexit        __section(.cpuexit.text) __exitused __cold notrace

#define __cpuexitdata    __section(.cpuexit.data)

#define __cpuexitconst   __section(.cpuexit.rodata)

#define __cpuexitconst   __constsection(.cpuexit.rodata)



/* Used for MEMORY_HOTPLUG */

#define __meminit        __section(.meminit.text) __cold notrace

#define __meminitdata    __section(.meminit.data)

#define __meminitconst   __section(.meminit.rodata)

#define __meminitconst   __constsection(.meminit.rodata)

#define __memexit        __section(.memexit.text) __exitused __cold notrace

#define __memexitdata    __section(.memexit.data)

#define __memexitconst   __section(.memexit.rodata)

#define __memexitconst   __constsection(.memexit.rodata)



/* For assembly routines */

#define __HEAD		.section	".head.text","ax"

init/Kconfig

+6 −0
Original line number Diff line number Diff line
@@ -1581,4 +1581,10 @@ config PADATA 
	depends on SMP

	bool



# Can be selected by architectures with broken toolchains

# that get confused by correct const<->read_only section

# mappings

config BROKEN_RODATA

	bool



source "kernel/Kconfig.locks"