Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 74ed7e62 authored by Joern Engel's avatar Joern Engel Committed by Nicholas Bellinger
Browse files

target: remove some smp_mb__after_atomic()s 



atomic_inc_return() already does an implicit memory barrier and the
second case was moved from an atomic to a plain flag operation.  If a
barrier were needed in the second case, it would have to be smp_mb(),
not a variant optimized away for x86 and other architectures.

Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 8f832690

drivers/target/target_core_transport.c

+0 −2
Original line number Diff line number Diff line
@@ -1166,7 +1166,6 @@ transport_check_alloc_task_attr(struct se_cmd *cmd) 
	 * Dormant to Active status.

	 */

	cmd->se_ordered_id = atomic_inc_return(&dev->dev_ordered_id);

	smp_mb__after_atomic();

	pr_debug("Allocated se_ordered_id: %u for Task Attr: 0x%02x on %s\n",

			cmd->se_ordered_id, cmd->sam_task_attr,

			dev->transport->name);
@@ -2896,7 +2895,6 @@ void transport_send_task_abort(struct se_cmd *cmd) 
		if (cmd->se_tfo->write_pending_status(cmd) != 0) {

			cmd->transport_state |= CMD_T_ABORTED;

			cmd->se_cmd_flags |= SCF_SEND_DELAYED_TAS;

			smp_mb__after_atomic();

			return;

		}

	}