Commit 7378c38a authored May 25, 2017 by Chris Redpath Committed by Andres Oportus Jul 18, 2017

UPSTREAM: cpufreq: schedutil: Fix per-CPU structure initialization in sugov_start()



sugov_start() only initializes struct sugov_cpu per-CPU structures
for shared policies, but it should do that for single-CPU policies too.

That in particular makes the IO-wait boost mechanism work in the
cases when cpufreq policies correspond to individual CPUs.

Fixes: 21ca6d2c52f8 (cpufreq: schedutil: Add iowait boosting)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: 4.9+ <stable@vger.kernel.org> # 4.9+
(cherry picked from commit 4296f23ed49a15d36949458adcc66ff993dee2a8)
(we use SCHED_CPUFREQ_DL instead of SCHED_CPUFREQ_RT in cpu->flags)
Signed-off-by: Chris Redpath <chris.redpath@arm.com>
Change-Id: I5b837a0ee4432115d85caa1a9808ea61e1e1b07f

parent cbaccede

kernel/sched/cpufreq_schedutil.c

+7 −13

Original line number	Diff line number	Diff line
		@@ -691,21 +691,15 @@ static int sugov_start(struct cpufreq_policy *policy)
		for_each_cpu(cpu, policy->cpus) {
		struct sugov_cpu *sg_cpu = &per_cpu(sugov_cpu, cpu);

		memset(sg_cpu, 0, sizeof(*sg_cpu));
		sg_cpu->sg_policy = sg_policy;
		if (policy_is_shared(policy)) {
		sg_cpu->util = 0;
		sg_cpu->max = 0;
		sg_cpu->flags = SCHED_CPUFREQ_DL;
		sg_cpu->last_update = 0;
		sg_cpu->iowait_boost = 0;
		sg_cpu->iowait_boost_max = policy->cpuinfo.max_freq;
		cpufreq_add_update_util_hook(cpu, &sg_cpu->update_util,
		sugov_update_shared);
		} else {
		cpufreq_add_update_util_hook(cpu, &sg_cpu->update_util,
		policy_is_shared(policy) ?
		sugov_update_shared :
		sugov_update_single);
		}
		}
		return 0;
		}