Commit 6f7d7984 authored Dec 01, 2014 by Sasha Levin Committed by John Stultz May 22, 2015

time: Make sure tz_minuteswest is set to a valid value when setting time

Invalid values may overflow later, leading to undefined behaviour when
multiplied by 60 to get the amount of seconds.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: John Stultz <john.stultz@linaro.org>

parent 4e3d9cb0

kernel/time/time.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -173,6 +173,10 @@ int do_sys_settimeofday(const struct timespec tv, const struct timezone tz)
		return error;

		if (tz) {
		/* Verify we're witin the +-15 hrs range */
		if (tz->tz_minuteswest > 1560 \|\| tz->tz_minuteswest < -1560)
		return -EINVAL;

		sys_tz = *tz;
		update_vsyscall_tz();
		if (firsttime) {