Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6d072d78 authored by Jean Delvare's avatar Jean Delvare Committed by Jean Delvare
Browse files

i2c/tps65010: Add missing intialization of client data 



tps65010_remove() calls i2c_get_clientdata(client) but the client data
is never set during initialization, so it gets a NULL pointer at best.

I guess it was never spotted because the tps65010 driver is typically
not built modular so this function is discarded.

Signed-off-by: default avatarJean Delvare <khali@linux-fr.org>
Cc: David Brownell <dbrownell@users.sourceforge.net>
parent 1842cc2e

drivers/i2c/chips/tps65010.c

+2 −0
Original line number Diff line number Diff line
@@ -527,6 +527,7 @@ static int __exit tps65010_remove(struct i2c_client *client) 
	flush_scheduled_work();

	debugfs_remove(tps->file);

	kfree(tps);

	i2c_set_clientdata(client, NULL);

	the_tps = NULL;

	return 0;

}
@@ -615,6 +616,7 @@ static int tps65010_probe(struct i2c_client *client) 
		i2c_smbus_read_byte_data(client, TPS_DEFGPIO),

		i2c_smbus_read_byte_data(client, TPS_MASK3));



	i2c_set_clientdata(client, tps);

	the_tps = tps;



#if	defined(CONFIG_USB_GADGET) && !defined(CONFIG_USB_OTG)