Commit 68e3b4e8 authored May 03, 2016 by Phil Turnbull Committed by Greg Kroah-Hartman Aug 11, 2019

netfilter: nfnetlink_acct: validate NFACCT_QUOTA parameter



[ Upstream commit eda3fc50daa93b08774a18d51883c5a5d8d85e15 ]

If a quota bit is set in NFACCT_FLAGS but the NFACCT_QUOTA parameter is
missing then a NULL pointer dereference is triggered. CAP_NET_ADMIN is
required to trigger the bug.

Signed-off-by: Phil Turnbull <phil.turnbull@oracle.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent ebb9ffd1

net/netfilter/nfnetlink_acct.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -97,6 +97,8 @@ nfnl_acct_new(struct sock nfnl, struct sk_buff skb,
		return -EINVAL;
		if (flags & NFACCT_F_OVERQUOTA)
		return -EINVAL;
		if ((flags & NFACCT_F_QUOTA) && !tb[NFACCT_QUOTA])
		return -EINVAL;

		size += sizeof(u64);
		}