Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6896b3dd authored by Yuval Mintz's avatar Yuval Mintz Committed by Greg Kroah-Hartman
Browse files

bnx2x: Prevent false warning for lack of FC NPIV 



commit 1e6bb1a3540fec3ef112b9a89dda88e684c3ff59 upstream.

Not all adapters have FC-NPIV configured. If bnx2fc is used with such an
adapter, driver would read irrelevant data from the the nvram and log
"FC-NPIV table with bad length..." In system logs.

Simply accept that reading '0' as the feature offset in nvram indicates
the feature isn't there and return.

Reported-by: default avatarAndrew Patterson <andrew.patterson@hpe.com>
Signed-off-by: default avatarYuval Mintz <Yuval.Mintz@qlogic.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
Signed-off-by: default avatarJuerg Haefliger <juerg.haefliger@hpe.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0c4d7bf

drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c

+4 −0
Original line number Diff line number Diff line
@@ -14819,6 +14819,10 @@ static int bnx2x_get_fc_npiv(struct net_device *dev, 
	}



	offset = SHMEM2_RD(bp, fc_npiv_nvram_tbl_addr[BP_PORT(bp)]);

	if (!offset) {

		DP(BNX2X_MSG_MCP, "No FC-NPIV in NVRAM\n");

		goto out;

	}

	DP(BNX2X_MSG_MCP, "Offset of FC-NPIV in NVRAM: %08x\n", offset);



	/* Read the table contents from nvram */