Commit 688b744d authored Apr 24, 2008 by Harvey Harrison Committed by Jason Wessel May 05, 2008

kgdb: fix signedness mixmatches, add statics, add declaration to header

Noticed by sparse:
arch/x86/kernel/kgdb.c:556:15: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
kernel/kgdb.c:149:8: warning: symbol 'kgdb_do_roundup' was not declared. Should it be static?
kernel/kgdb.c:193:22: warning: symbol 'kgdb_arch_pc' was not declared. Should it be static?
kernel/kgdb.c:712:5: warning: symbol 'remove_all_break' was not declared. Should it be static?

Related to kgdb_hex2long:
arch/x86/kernel/kgdb.c:371:28: warning: incorrect type in argument 2 (different signedness)
arch/x86/kernel/kgdb.c:371:28: expected long *long_val
arch/x86/kernel/kgdb.c:371:28: got unsigned long *<noident>
kernel/kgdb.c:469:27: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:469:27: expected long *long_val
kernel/kgdb.c:469:27: got unsigned long *<noident>
kernel/kgdb.c:470:27: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:470:27: expected long *long_val
kernel/kgdb.c:470:27: got unsigned long *<noident>
kernel/kgdb.c:894:27: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:894:27: expected long *long_val
kernel/kgdb.c:894:27: got unsigned long *<noident>
kernel/kgdb.c:895:27: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:895:27: expected long *long_val
kernel/kgdb.c:895:27: got unsigned long *<noident>
kernel/kgdb.c:1127:28: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:1127:28: expected long *long_val
kernel/kgdb.c:1127:28: got unsigned long *<noident>
kernel/kgdb.c:1132:25: warning: incorrect type in argument 2 (different signedness)
kernel/kgdb.c:1132:25: expected long *long_val
kernel/kgdb.c:1132:25: got unsigned long *<noident>

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent 7cfcd985

include/linux/kgdb.h

+3 −1

Original line number	Diff line number	Diff line
		@@ -261,10 +261,12 @@ struct kgdb_io {

		extern struct kgdb_arch arch_kgdb_ops;

		extern unsigned long __weak kgdb_arch_pc(int exception, struct pt_regs *regs);

		extern int kgdb_register_io_module(struct kgdb_io *local_kgdb_io_ops);
		extern void kgdb_unregister_io_module(struct kgdb_io *local_kgdb_io_ops);

		extern int kgdb_hex2long(char *ptr, long long_val);
		extern int kgdb_hex2long(char *ptr, unsigned long long_val);
		extern int kgdb_mem2hex(char mem, char buf, int count);
		extern int kgdb_hex2mem(char buf, char mem, int count);

kernel/kgdb.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -61,7 +61,7 @@ struct kgdb_state {
		int err_code;
		int cpu;
		int pass_exception;
		long threadid;
		unsigned long threadid;
		long kgdb_usethreadid;
		struct pt_regs *linux_regs;
		};
		@@ -146,7 +146,7 @@ atomic_t kgdb_cpu_doing_single_step = ATOMIC_INIT(-1);
		* the other CPUs might interfere with your debugging context, so
		* use this with care:
		*/
		int kgdb_do_roundup = 1;
		static int kgdb_do_roundup = 1;

		static int __init opt_nokgdbroundup(char *str)
		{
		@@ -438,7 +438,7 @@ int kgdb_hex2mem(char buf, char mem, int count)
		* While we find nice hex chars, build a long_val.
		* Return number of chars processed.
		*/
		int kgdb_hex2long(char *ptr, long long_val)
		int kgdb_hex2long(char *ptr, unsigned long long_val)
		{
		int hex_val;
		int num = 0;
		@@ -709,7 +709,7 @@ int kgdb_isremovedbreak(unsigned long addr)
		return 0;
		}

		int remove_all_break(void)
		static int remove_all_break(void)
		{
		unsigned long addr;
		int error;