Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 67852dc0 authored by David Howells's avatar David Howells Committed by David Woodhouse
Browse files

Fix a const pointer usage warning in the Digigram pcxhr soundcard driver 



Fix a const pointer usage warning in the Digigram pcxhr compatible soundcard
driver.  A const pointer is being passed to copy_from_user() to load the
firmware into.  This is okay in this case because the function has allocated
the firmware struct itself, but the const qualifier is part of the firmware
struct - so the patch casts the const away.

Signed-off-by: default avatarDavid Howells <dhowells@redhat.com>
Signed-off-by: default avatarDavid Woodhouse <David.Woodhouse@intel.com>
parent 9b8a3e4c

sound/pci/pcxhr/pcxhr_hwdep.c

+1 −1
Original line number Diff line number Diff line
@@ -394,7 +394,7 @@ static int pcxhr_hwdep_dsp_load(struct snd_hwdep *hw, 
			   (unsigned long)fw.size);

		return -ENOMEM;

	}

	if (copy_from_user(fw.data, dsp->image, dsp->length)) {

	if (copy_from_user((void *)fw.data, dsp->image, dsp->length)) {

		vfree(fw.data);

		return -EFAULT;

	}