Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 66415f6b authored by Zhao Hongjiang's avatar Zhao Hongjiang Committed by Jan Kara
Browse files

ext3: fix return values on parse_options() failure 



parse_options() in ext3 should return 0 when parse the mount options fails.

Signed-off-by: default avatarZhao Hongjiang <zhaohongjiang@huawei.com>
Reviewed-by: default avatarLukas Czerner <lczerner@redhat.com>
Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent ae2cf428

fs/ext3/super.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb, 
			uid = make_kuid(current_user_ns(), option);

			uid = make_kuid(current_user_ns(), option);

			if (!uid_valid(uid)) {

			if (!uid_valid(uid)) {

				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);

				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);

				return -1;

				return 0;





			}

			}

			sbi->s_resuid = uid;

			sbi->s_resuid = uid;
@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb, 
			gid = make_kgid(current_user_ns(), option);

			gid = make_kgid(current_user_ns(), option);

			if (!gid_valid(gid)) {

			if (!gid_valid(gid)) {

				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);

				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);

				return -1;

				return 0;

			}

			}

			sbi->s_resgid = gid;

			sbi->s_resgid = gid;

			break;

			break;