Commit 6637eca3 authored Apr 29, 2013 by Sachin Kamat Committed by Linus Torvalds Apr 29, 2013

drivers/video/exynos/exynos_mipi_dsi.c: convert to devm_ioremap_resource()



Use the newly introduced devm_ioremap_resource() instead of
devm_request_and_ioremap() which provides more consistent error
handling.

devm_ioremap_resource() provides its own error messages; so all explicit
error messages can be removed from the failure code paths.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Cc: Donghwa Lee <dh09.lee@samsung.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Reviewed-by: Thierry Reding <thierry.reding@avionic-design.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 68a2d20b

drivers/video/exynos/exynos_mipi_dsi.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -32,6 +32,7 @@
		#include <linux/notifier.h>
		#include <linux/regulator/consumer.h>
		#include <linux/pm_runtime.h>
		#include <linux/err.h>

		#include <video/exynos_mipi_dsim.h>

		@@ -382,10 +383,9 @@ static int exynos_mipi_dsi_probe(struct platform_device *pdev)

		res = platform_get_resource(pdev, IORESOURCE_MEM, 0);

		dsim->reg_base = devm_request_and_ioremap(&pdev->dev, res);
		if (!dsim->reg_base) {
		dev_err(&pdev->dev, "failed to remap io region\n");
		ret = -ENOMEM;
		dsim->reg_base = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(dsim->reg_base)) {
		ret = PTR_ERR(dsim->reg_base);
		goto error;
		}