Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 608fb9c2 authored by Gavin Shan's avatar Gavin Shan Committed by Michael Ellerman
Browse files

powerpc/powernv: Cleanup on EEH comments 



This applies cleanup on eeh-powernv.c, no functional changes:

   * Remove unnecessary comments and empty line.
   * Correct inaccurate comments.

Signed-off-by: default avatarGavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
parent 00ba05a1

arch/powerpc/platforms/powernv/eeh-powernv.c

+2 −11
Original line number Diff line number Diff line
@@ -43,17 +43,11 @@ 
static bool pnv_eeh_nb_init = false;

static int eeh_event_irq = -EINVAL;



/**

 * pnv_eeh_init - EEH platform dependent initialization

 *

 * EEH platform dependent initialization on powernv

 */

static int pnv_eeh_init(void)

{

	struct pci_controller *hose;

	struct pnv_phb *phb;



	/* We require OPALv3 */

	if (!firmware_has_feature(FW_FEATURE_OPALv3)) {

		pr_warn("%s: OPALv3 is required !\n",

			__func__);
@@ -77,9 +71,9 @@ static int pnv_eeh_init(void) 
		/*

		 * PE#0 should be regarded as valid by EEH core

		 * if it's not the reserved one. Currently, we

		 * have the reserved PE#0 and PE#127 for PHB3

		 * have the reserved PE#255 and PE#127 for PHB3

		 * and P7IOC separately. So we should regard

		 * PE#0 as valid for P7IOC.

		 * PE#0 as valid for PHB3 and P7IOC.

		 */

		if (phb->ioda.reserved_pe != 0)

			eeh_add_flag(EEH_VALID_PE_ZERO);
@@ -284,7 +278,6 @@ static int pnv_eeh_post_init(void) 
#endif /* CONFIG_DEBUG_FS */

	}





	return ret;

}
@@ -490,7 +483,6 @@ static int pnv_eeh_set_option(struct eeh_pe *pe, int option) 
	int opt, ret = 0;

	s64 rc;



	/* Sanity check on option */

	switch (option) {

	case EEH_OPT_DISABLE:

		return -EPERM;
@@ -1065,7 +1057,6 @@ static int pnv_eeh_err_inject(struct eeh_pe *pe, int type, int func, 
	struct pnv_phb *phb = hose->private_data;

	s64 rc;



	/* Sanity check on error type */

	if (type != OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR &&

	    type != OPAL_ERR_INJECT_TYPE_IOA_BUS_ERR64) {

		pr_warn("%s: Invalid error type %d\n",