Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ecf6e40 authored by Devendra Naga's avatar Devendra Naga Committed by Bryan Wu
Browse files

leds/leds-s3c24xx: use devm_gpio_request 



why?
because if the led_classdev_register fails we wont do gpio free
because using devm_ functions, there is no need for error paths

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Signed-off-by: default avatarBryan Wu <bryan.wu@canonical.com>
parent a209f766

drivers/leds/leds-s3c24xx.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -65,7 +65,6 @@ static int s3c24xx_led_remove(struct platform_device *dev) 
	struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);

	struct s3c24xx_gpio_led *led = pdev_to_gpio(dev);





	led_classdev_unregister(&led->cdev);

	led_classdev_unregister(&led->cdev);

	gpio_free(led->pdata->gpio);





	return 0;

	return 0;

}

}
@@ -92,7 +91,7 @@ static int s3c24xx_led_probe(struct platform_device *dev) 




	led->pdata = pdata;

	led->pdata = pdata;





	ret = gpio_request(pdata->gpio, "S3C24XX_LED");

	ret = devm_gpio_request(&dev->dev, pdata->gpio, "S3C24XX_LED");

	if (ret < 0)

	if (ret < 0)

		return ret;

		return ret;