Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5cb33e21 authored by Jani Nikula's avatar Jani Nikula Committed by Tomi Valkeinen
Browse files

OMAP: DSS2: OMAPFB: Fix sysfs mirror input check 



Using bool silently converted input to 0 or 1, making the range check
useless. Use unsigned long instead, and convert to bool later. Found by
Coverity.

Signed-off-by: default avatarJani Nikula <ext-jani.1.nikula@nokia.com>
Signed-off-by: default avatarTomi Valkeinen <tomi.valkeinen@nokia.com>
parent 7f8b1830

drivers/video/omap2/omapfb/omapfb-sysfs.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -102,7 +102,7 @@ static ssize_t store_mirror(struct device *dev, 
{

{

	struct fb_info *fbi = dev_get_drvdata(dev);

	struct fb_info *fbi = dev_get_drvdata(dev);

	struct omapfb_info *ofbi = FB2OFB(fbi);

	struct omapfb_info *ofbi = FB2OFB(fbi);

	bool mirror;

	unsigned long mirror;

	int r;

	int r;

	struct fb_var_screeninfo new_var;

	struct fb_var_screeninfo new_var;