Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5ab82a11 authored by Lv Zheng's avatar Lv Zheng Committed by Rafael J. Wysocki
Browse files

ACPI / EC: Remove storming threashold enlarging quirk. 

This patch removes the storming threashold enlarging quirk.

After applying the following commit, we can notice that there is no no-op
GPE handling invocation can be observed, thus it is unlikely that the
no-op counts can exceed the storming threashold:
  Commit: ca37bfdf
  Subject: ACPI / EC: Fix several GPE handling issues by deploying ACPI_GPE_DISPATCH_RAW_HANDLER mode.
Even when the storming happens, we have already limited its affection to
the only transaction and no further transactions will be affected. This is
done by this commit:
  Commit: e1d4d90f
  Subject: ACPI / EC: Refine command storm prevention support

So it's time to remove this quirk.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=45151


Signed-off-by: default avatarLv Zheng <lv.zheng@intel.com>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 7c0b2595

drivers/acpi/ec.c

+0 −15
Original line number Diff line number Diff line
@@ -1246,17 +1246,6 @@ static int ec_flag_msi(const struct dmi_system_id *id) 
	return 0;

}



/*

 * Clevo M720 notebook actually works ok with IRQ mode, if we lifted

 * the GPE storm threshold back to 20

 */

static int ec_enlarge_storm_threshold(const struct dmi_system_id *id)

{

	pr_debug("Setting the EC GPE storm threshold to 20\n");

	ec_storm_threshold  = 20;

	return 0;

}



/*

 * Acer EC firmware refuses to respond QR_EC when SCI_EVT is not set, for

 * which case, we complete the QR_EC without issuing it to the firmware.
@@ -1329,10 +1318,6 @@ static struct dmi_system_id ec_dmi_table[] __initdata = { 
	ec_validate_ecdt, "ASUS hardware", {

	DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer Inc.") }, NULL},

	{

	ec_enlarge_storm_threshold, "CLEVO hardware", {

	DMI_MATCH(DMI_SYS_VENDOR, "CLEVO Co."),

	DMI_MATCH(DMI_PRODUCT_NAME, "M720T/M730T"),}, NULL},

	{

	ec_skip_dsdt_scan, "HP Folio 13", {

	DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"),

	DMI_MATCH(DMI_PRODUCT_NAME, "HP Folio 13"),}, NULL},