Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5a9b659e authored by Josef Bacik's avatar Josef Bacik Committed by Greg Kroah-Hartman
Browse files

Btrfs: don't leak reloc root nodes on error 



commit 6bdf131fac2336adb1a628f992ba32384f653a55 upstream.

We don't track the reloc roots in any sort of normal way, so the only way the
root/commit_root nodes get free'd is if the relocation finishes successfully and
the reloc root is deleted.  Fix this by free'ing them in free_reloc_roots.
Thanks,

Signed-off-by: default avatarJosef Bacik <jbacik@fb.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8ca6845a

fs/btrfs/relocation.c

+4 −0
Original line number Diff line number Diff line
@@ -2350,6 +2350,10 @@ void free_reloc_roots(struct list_head *list) 
	while (!list_empty(list)) {

		reloc_root = list_entry(list->next, struct btrfs_root,

					root_list);

		free_extent_buffer(reloc_root->node);

		free_extent_buffer(reloc_root->commit_root);

		reloc_root->node = NULL;

		reloc_root->commit_root = NULL;

		__del_reloc_root(reloc_root);

	}

}