Commit 551c012d authored Dec 12, 2006 by Tejun Heo Committed by Jeff Garzik Dec 16, 2006

[PATCH] ahci: do not mangle saved HOST_CAP while resetting controller



Do not mangle with HOST_CAP while resetting controller.  The code is
there for a historical reason.  The mangling breaks controller feature
detection and 0 PORTS_IMPL workaround code.

This problem was spotted by Manoj Kasichainula.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Manoj Kasichainula <manoj@io.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 33480a0e

drivers/ata/ahci.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -645,8 +645,6 @@ static int ahci_reset_controller(void __iomem mmio, struct pci_dev pdev)
		u32 cap_save, impl_save, tmp;

		cap_save = readl(mmio + HOST_CAP);
		cap_save &= ( (1<<28) \| (1<<17) );
		cap_save \|= (1 << 27);
		impl_save = readl(mmio + HOST_PORTS_IMPL);

		/* global controller reset */