Commit 54e2c2c1 authored Sep 16, 2014 by David Howells

KEYS: Reinstate EPERM for a key type name beginning with a '.'



Reinstate the generation of EPERM for a key type name beginning with a '.' in
a userspace call.  Types whose name begins with a '.' are internal only.

The test was removed by:

	commit a4e3b8d7
	Author: Mimi Zohar <zohar@linux.vnet.ibm.com>
	Date:   Thu May 22 14:02:23 2014 -0400
	Subject: KEYS: special dot prefixed keyring name bug fix

I think we want to keep the restriction on type name so that userspace can't
add keys of a special internal type.

Note that removal of the test causes several of the tests in the keyutils
testsuite to fail.

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Vivek Goyal <vgoyal@redhat.com>
cc: Mimi Zohar <zohar@linux.vnet.ibm.com>

parent 478d0855

security/keys/keyctl.c

+2 −0

Original line number	Original line	Diff line number	Diff line
	@@ -37,6 +37,8 @@ static int key_get_type_from_user(char *type,
	return ret;		return ret;
	if (ret == 0 \|\| ret >= len)		if (ret == 0 \|\| ret >= len)
	return -EINVAL;		return -EINVAL;
			if (type[0] == '.')
			return -EPERM;
	type[len - 1] = '\0';		type[len - 1] = '\0';
	return 0;		return 0;
	}		}