Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 5421853c authored by Veera Sundaram Sankaran's avatar Veera Sundaram Sankaran
Browse files

msm: mdss: remove always source split quirk setting 



The quirk setting to enable source split always was added along
with the multirect changes from MDP rev 3.0. But there is no
special requirement for enabling it with multirect as the source
split behavior remains the same. Source split  is required only
when the layer lies in both the LM. Enabling source split with
partial update, when updating only one LM causes MDP hang due to
invalid configuration. Fix the configs by removing the unnecessary
always source split quirk setting.

Change-Id: Iadaafa64d2c1908b04498d0a88dd612dbc36dae8
Signed-off-by: default avatarVeera Sundaram Sankaran <veeras@codeaurora.org>
parent e94b446e

drivers/video/fbdev/msm/mdss_mdp.c

+0 −1
Original line number Diff line number Diff line
@@ -1947,7 +1947,6 @@ static void mdss_mdp_hw_rev_caps_init(struct mdss_data_type *mdata) 
		mdss_mdp_init_default_prefill_factors(mdata);

		mdss_set_quirk(mdata, MDSS_QUIRK_DSC_RIGHT_ONLY_PU);

		mdss_set_quirk(mdata, MDSS_QUIRK_DSC_2SLICE_PU_THRPUT);

		mdss_set_quirk(mdata, MDSS_QUIRK_SRC_SPLIT_ALWAYS);

		mdata->has_wb_ubwc = true;

		set_bit(MDSS_CAPS_10_BIT_SUPPORTED, mdata->mdss_caps_map);

		set_bit(MDSS_CAPS_AVR_SUPPORTED, mdata->mdss_caps_map);

drivers/video/fbdev/msm/mdss_mdp_layer.c

+1 −4
Original line number Diff line number Diff line
@@ -347,10 +347,7 @@ static void __update_avr_info(struct mdss_mdp_ctl *ctl, 
 */

static bool __layer_needs_src_split(struct mdp_input_layer *layer)

{

	struct mdss_data_type *mdata = mdss_mdp_get_mdata();



	return (layer->flags & MDP_LAYER_ASYNC) ||

		mdss_has_quirk(mdata, MDSS_QUIRK_SRC_SPLIT_ALWAYS);

	return (layer->flags & MDP_LAYER_ASYNC);

}



static int __async_update_position_check(struct msm_fb_data_type *mfd,