Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4fdeddfe authored by Gilad Ben-Yossef's avatar Gilad Ben-Yossef Committed by David S. Miller
Browse files

dsa: fix promiscuity leak on slave dev open error 



DSA master netdev promiscuity counter was not being properly
decremented on slave device open error path.

Signed-off-by: default avatarGilad Ben-Yossef <gilad@benyossef.com>
CC: Gilad Ben-Yossef <giladb@ezchip.com>
CC: David S. Miller <davem@davemloft.net>
CC: Florian Fainelli <f.fainelli@gmail.com>
CC: Guenter Roeck <linux@roeck-us.net>
CC: Andrew Lunn <andrew@lunn.ch>
CC: Scott Feldman <sfeldma@gmail.com>
Acked-by: default avatarAndrew Lunn <andrew@lunn.ch>
Acked-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 14e28b1d

net/dsa/slave.c

+1 −1
Original line number Diff line number Diff line
@@ -112,7 +112,7 @@ static int dsa_slave_open(struct net_device *dev) 


clear_promisc:

	if (dev->flags & IFF_PROMISC)

		dev_set_promiscuity(master, 0);

		dev_set_promiscuity(master, -1);

clear_allmulti:

	if (dev->flags & IFF_ALLMULTI)

		dev_set_allmulti(master, -1);