Commit 4efd587b authored Sep 29, 2006 by David Woodhouse Committed by Linus Torvalds Sep 29, 2006

[PATCH] Fix uninitialised spinlock in via-pmu-backlight code.



The uninitialised pmu_backlight_lock causes the current Fedora test kernel
(which has spinlock debugging enabled) to panic on suspend.

This is suboptimal, so I fixed it.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Michael Hanselmann <linux-kernel@hansmi.ch>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 910067d1

drivers/macintosh/via-pmu-backlight.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -16,7 +16,7 @@
		#define MAX_PMU_LEVEL 0xFF

		static struct backlight_properties pmu_backlight_data;
		static spinlock_t pmu_backlight_lock;
		static DEFINE_SPINLOCK(pmu_backlight_lock);
		static int sleeping;
		static u8 bl_curve[FB_BACKLIGHT_LEVELS];