Commit 4e7aba73 authored May 30, 2007 by Mike Christie Committed by James Bottomley Jun 02, 2007

[SCSI] iscsi_tcp: fix fd leak



This patch should fix the file descriptor leak problem. A quick look
through the kernel shows that users of sockfd_lookup use sockfd_put to
release their handle. We were using sock_release which from the comments
and code look like it does not release the get() on the file from the
lookup.

Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>

parent 0ab823db

drivers/scsi/iscsi_tcp.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -29,6 +29,7 @@
		#include <linux/types.h>
		#include <linux/list.h>
		#include <linux/inet.h>
		#include <linux/file.h>
		#include <linux/blkdev.h>
		#include <linux/crypto.h>
		#include <linux/delay.h>
		@@ -1878,7 +1879,7 @@ iscsi_tcp_release_conn(struct iscsi_conn *conn)
		iscsi_conn_restore_callbacks(tcp_conn);
		sock_put(tcp_conn->sock->sk);

		sock_release(tcp_conn->sock);
		sockfd_put(tcp_conn->sock);
		tcp_conn->sock = NULL;
		conn->recv_lock = NULL;
		}