Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4d18760c authored by Bjorn Helgaas's avatar Bjorn Helgaas
Browse files

PCI: Use PCI_MSIX_TABLE_BIR, not PCI_MSIX_FLAGS_BIRMASK 



PCI_MSIX_FLAGS_BIRMASK is mis-named because the BIR mask is in the
Table Offset register, not the flags ("Message Control" per spec)
register.

Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
parent 78b5a310

drivers/pci/msi.c

+2 −2
Original line number Diff line number Diff line
@@ -605,8 +605,8 @@ static void __iomem *msix_map_region(struct pci_dev *dev, unsigned nr_entries) 


	pci_read_config_dword(dev, dev->msix_cap + PCI_MSIX_TABLE,

			      &table_offset);

	bir = (u8)(table_offset & PCI_MSIX_FLAGS_BIRMASK);

	table_offset &= ~PCI_MSIX_FLAGS_BIRMASK;

	bir = (u8)(table_offset & PCI_MSIX_TABLE_BIR);

	table_offset &= PCI_MSIX_TABLE_OFFSET;

	phys_addr = pci_resource_start(dev, bir) + table_offset;



	return ioremap_nocache(phys_addr, nr_entries * PCI_MSIX_ENTRY_SIZE);