Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4be05b0a authored by Takashi Iwai's avatar Takashi Iwai Committed by Greg Kroah-Hartman
Browse files

ALSA: ali5451: Fix out-of-bound position reporting 



commit db68577966abc1aeae4ec597b3dcfa0d56e92041 upstream.

The pointer callbacks of ali5451 driver may return the value at the
boundary occasionally, and it results in the kernel warning like
  snd_ali5451 0000:00:06.0: BUG: , pos = 16384, buffer size = 16384, period size = 1024

It seems that folding the position offset is enough for fixing the
warning and no ill-effect has been seen by that.

Reported-by: default avatarEnrico Mioso <mrkiko.rs@gmail.com>
Tested-by: default avatarEnrico Mioso <mrkiko.rs@gmail.com>
Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 78c7b55b

sound/pci/ali5451/ali5451.c

+2 −0
Original line number Diff line number Diff line
@@ -1408,6 +1408,7 @@ snd_ali_playback_pointer(struct snd_pcm_substream *substream) 
	spin_unlock(&codec->reg_lock);

	dev_dbg(codec->card->dev, "playback pointer returned cso=%xh.\n", cso);



	cso %= runtime->buffer_size;

	return cso;

}
@@ -1428,6 +1429,7 @@ static snd_pcm_uframes_t snd_ali_pointer(struct snd_pcm_substream *substream) 
	cso = inw(ALI_REG(codec, ALI_CSO_ALPHA_FMS + 2));

	spin_unlock(&codec->reg_lock);



	cso %= runtime->buffer_size;

	return cso;

}