Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4a4d371a authored by Jiri Olsa's avatar Jiri Olsa Committed by Arnaldo Carvalho de Melo
Browse files

perf record: Remove -f/--force option 



It no longer have any affect on the processing and is marked as obsolete
anyway.

Signed-off-by: default avatarJiri Olsa <jolsa@redhat.com>
Cc: Andi Kleen <ak@linux.intel.com>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/n/tip-tvwyspiqr4getzfib2lw06ty@git.kernel.org
Link: http://lkml.kernel.org/r/1372307120-737-1-git-send-email-namhyung@kernel.org


[ combined patch removing the -f usage in various sub-commands, such as 'perf sched', etc, by Namhyung Kim ]
Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
parent 563aecb2

tools/perf/Documentation/examples.txt

+2 −2
Original line number Diff line number Diff line
@@ -66,7 +66,7 @@ Furthermore, these tracepoints can be used to sample the workload as 
well. For example the page allocations done by a 'git gc' can be

captured the following way:



 titan:~/git> perf record -f -e kmem:mm_page_alloc -c 1 ./git gc

 titan:~/git> perf record -e kmem:mm_page_alloc -c 1 ./git gc

 Counting objects: 1148, done.

 Delta compression using up to 2 threads.

 Compressing objects: 100% (450/450), done.
@@ -120,7 +120,7 @@ Furthermore, call-graph sampling can be done too, of page 
allocations - to see precisely what kind of page allocations there

are:



 titan:~/git> perf record -f -g -e kmem:mm_page_alloc -c 1 ./git gc

 titan:~/git> perf record -g -e kmem:mm_page_alloc -c 1 ./git gc

 Counting objects: 1148, done.

 Delta compression using up to 2 threads.

 Compressing objects: 100% (450/450), done.

tools/perf/Documentation/perf-record.txt

+0 −4
Original line number Diff line number Diff line
@@ -70,10 +70,6 @@ OPTIONS 
--no-delay::

	Collect data without buffering.



-f::

--force::

	Overwrite existing data file. (deprecated)



-c::

--count=::

	Event period to sample.

tools/perf/builtin-kmem.c

+1 −1
Original line number Diff line number Diff line
@@ -708,7 +708,7 @@ static int parse_line_opt(const struct option *opt __maybe_unused, 
static int __cmd_record(int argc, const char **argv)

{

	const char * const record_args[] = {

	"record", "-a", "-R", "-f", "-c", "1",

	"record", "-a", "-R", "-c", "1",

	"-e", "kmem:kmalloc",

	"-e", "kmem:kmalloc_node",

	"-e", "kmem:kfree",

tools/perf/builtin-lock.c

+1 −1
Original line number Diff line number Diff line
@@ -878,7 +878,7 @@ static int __cmd_report(void) 
static int __cmd_record(int argc, const char **argv)

{

	const char *record_args[] = {

		"record", "-R", "-f", "-m", "1024", "-c", "1",

		"record", "-R", "-m", "1024", "-c", "1",

	};

	unsigned int rec_argc, i, j;

	const char **rec_argv;

tools/perf/builtin-record.c

+0 −3
Original line number Diff line number Diff line
@@ -74,7 +74,6 @@ struct perf_record { 
	int			realtime_prio;

	bool			no_buildid;

	bool			no_buildid_cache;

	bool			force;

	long			samples;

	off_t			post_processing_offset;

};
@@ -856,8 +855,6 @@ const struct option record_options[] = { 
			    "system-wide collection from all CPUs"),

	OPT_STRING('C', "cpu", &record.opts.target.cpu_list, "cpu",

		    "list of cpus to monitor"),

	OPT_BOOLEAN('f', "force", &record.force,

			"overwrite existing data file (deprecated)"),

	OPT_U64('c', "count", &record.opts.user_interval, "event period to sample"),

	OPT_STRING('o', "output", &record.output_name, "file",

		    "output file name"),