Commit 47caff4c authored Oct 20, 2017 by David Lin Committed by Greg Hackmann Oct 30, 2017

FROMLIST: kbuild: clang: fix build failures with sparse check



We should avoid using the space character when passing arguments to
clang, because static code analysis check tool such as sparse may
misinterpret the arguments followed by spaces as build targets hence
cause the build to fail.

Signed-off-by: David Lin <dtwlin@google.com>
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
(cherry picked from linux-kbuild commit bb3f38c3c5b759163e09b9152629cc789731de47)

Bug: 66969589
Change-Id: I055719cbc89e7a12d1f46f0a9c2152738a278d2a
[ghackmann@google.com: tweak to preserve AOSP-specific CLANG_TRIPLE]
Signed-off-by: Greg Hackmann <ghackmann@google.com>

parent fc7a7876

Makefile

+2 −2

Original line number	Diff line number	Diff line
		@@ -696,11 +696,11 @@ KBUILD_CFLAGS += $(stackp-flag)
		ifeq ($(cc-name),clang)
		ifneq ($(CROSS_COMPILE),)
		CLANG_TRIPLE ?= $(CROSS_COMPILE)
		CLANG_TARGET := -target $(notdir $(CLANG_TRIPLE:%-=%))
		CLANG_TARGET := --target=$(notdir $(CLANG_TRIPLE:%-=%))
		GCC_TOOLCHAIN := $(realpath $(dir $(shell which $(LD)))/..)
		endif
		ifneq ($(GCC_TOOLCHAIN),)
		CLANG_GCC_TC := -gcc-toolchain $(GCC_TOOLCHAIN)
		CLANG_GCC_TC := --gcc-toolchain=$(GCC_TOOLCHAIN)
		endif
		KBUILD_CFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)
		KBUILD_AFLAGS += $(CLANG_TARGET) $(CLANG_GCC_TC)