Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4794e0b1 authored by Kiran Gunda's avatar Kiran Gunda Committed by Gerrit - the friendly Code Review server
Browse files

leds: qpnp-flash: Introduce a function pointer for qpnp_flash_led_prepare 



Introduce a function pointer to avoid the compilation error
due the same function name used in the legacy and v2 flash
drivers. These two drivers need to be enabled in a single
defconfig that supports multiple hardware platforms to achieve
the binary compatibility.

Change-Id: I1ded3d4d9013c6f7f56e0a8952f4b45d20b07326
Signed-off-by: default avatarKiran Gunda <kgunda@codeaurora.org>
Signed-off-by: default avatarShilpa Suresh <sbsure@codeaurora.org>
parent 77b03b19

drivers/leds/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -61,8 +61,8 @@ obj-$(CONFIG_LEDS_MAX8997) += leds-max8997.o 
obj-$(CONFIG_LEDS_LM355x)		+= leds-lm355x.o

obj-$(CONFIG_LEDS_BLINKM)		+= leds-blinkm.o

obj-$(CONFIG_LEDS_QPNP)			+= leds-qpnp.o

obj-$(CONFIG_LEDS_QPNP_FLASH)		+= leds-qpnp-flash.o

obj-$(CONFIG_LEDS_QPNP_FLASH_V2)        += leds-qpnp-flash-v2.o

obj-$(CONFIG_LEDS_QPNP_FLASH)		+= leds-qpnp-flash.o leds-qpnp-flash-common.o

obj-$(CONFIG_LEDS_QPNP_FLASH_V2)	+= leds-qpnp-flash-v2.o leds-qpnp-flash-common.o

obj-$(CONFIG_LEDS_QPNP_WLED)		+= leds-qpnp-wled.o

obj-$(CONFIG_LEDS_SYSCON)		+= leds-syscon.o

obj-$(CONFIG_LEDS_VERSATILE)		+= leds-versatile.o

drivers/leds/leds-qpnp-flash-common.c

0 → 100644
+16 −0
Original line number Diff line number Diff line 
/* Copyright (c) 2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and

 * only version 2 as published by the Free Software Foundation.

 *

 * This program is distributed in the hope that it will be useful,

 * but WITHOUT ANY WARRANTY; without even the implied warranty of

 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the

 * GNU General Public License for more details.

 */



#include <linux/leds-qpnp-flash.h>



int (*qpnp_flash_led_prepare)(struct led_trigger *trig, int options,

					int *max_current);

drivers/leds/leds-qpnp-flash-v2.c

+2 −1
Original line number Diff line number Diff line
@@ -1248,7 +1248,7 @@ static int qpnp_flash_led_switch_set(struct flash_switch_data *snode, bool on) 
	return 0;

}



int qpnp_flash_led_prepare(struct led_trigger *trig, int options,

static int qpnp_flash_led_prepare_v2(struct led_trigger *trig, int options,

					int *max_current)

{

	struct led_classdev *led_cdev;
@@ -2249,6 +2249,7 @@ static int qpnp_flash_led_probe(struct platform_device *pdev) 
	if (!led->pdata)

		return -ENOMEM;



	qpnp_flash_led_prepare = qpnp_flash_led_prepare_v2;

	rc = qpnp_flash_led_parse_common_dt(led, node);

	if (rc < 0) {

		pr_err("Failed to parse common flash LED device tree\n");

drivers/leds/leds-qpnp-flash.c

+3 −2
Original line number Diff line number Diff line 
/* Copyright (c) 2014-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2014-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -1207,7 +1207,7 @@ error_regulator_enable: 
	return rc;

}



int qpnp_flash_led_prepare(struct led_trigger *trig, int options,

static int qpnp_flash_led_prepare_v1(struct led_trigger *trig, int options,

					int *max_current)

{

	struct led_classdev *led_cdev = trigger_to_lcdev(trig);
@@ -2468,6 +2468,7 @@ static int qpnp_flash_led_probe(struct platform_device *pdev) 
	led->pdev = pdev;

	led->current_addr = FLASH_LED0_CURRENT(led->base);

	led->current2_addr = FLASH_LED1_CURRENT(led->base);

	qpnp_flash_led_prepare = qpnp_flash_led_prepare_v1;



	led->pdata = devm_kzalloc(&pdev->dev, sizeof(*led->pdata), GFP_KERNEL);

	if (!led->pdata)

include/linux/leds-qpnp-flash.h

+10 −3
Original line number Diff line number Diff line 
/* Copyright (c) 2016-2017, The Linux Foundation. All rights reserved.

/* Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.

 *

 * This program is free software; you can redistribute it and/or modify

 * it under the terms of the GNU General Public License version 2 and
@@ -21,7 +21,14 @@ 


#define FLASH_LED_PREPARE_OPTIONS_MASK	GENMASK(3, 0)



int qpnp_flash_led_prepare(struct led_trigger *trig, int options,

#if (defined CONFIG_LEDS_QPNP_FLASH || defined CONFIG_LEDS_QPNP_FLASH_V2)

extern int (*qpnp_flash_led_prepare)(struct led_trigger *trig, int options,

					int *max_current);



#else

static inline int qpnp_flash_led_prepare(struct led_trigger *trig, int options,

					int *max_current)

{

	return -ENODEV;

}

#endif

#endif