Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 478913fd authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Sebastian Reichel
Browse files

power: bq24190: Fix ignored supplicants 



The driver mismatched 'num_supplicants' with 'num_supplies' of
power_supply structure.

It provided list of supplicants (power_supply.supplied_to) but did
not set the number of supplicants. Instead it set the num_supplies which
is used when iterating over number of supplies (power_supply.supplied_from).

As a result the list of supplicants was ignored by core because its size
was 0.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: <stable@vger.kernel.org>
Fixes: d7bf353f ("bq24190_charger: Add support for TI BQ24190 Battery Charger")
Signed-off-by: default avatarSebastian Reichel <sre@kernel.org>
parent f1300e7f

drivers/power/bq24190_charger.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -929,7 +929,7 @@ static void bq24190_charger_init(struct power_supply *charger) 
	charger->properties = bq24190_charger_properties;

	charger->properties = bq24190_charger_properties;

	charger->num_properties = ARRAY_SIZE(bq24190_charger_properties);

	charger->num_properties = ARRAY_SIZE(bq24190_charger_properties);

	charger->supplied_to = bq24190_charger_supplied_to;

	charger->supplied_to = bq24190_charger_supplied_to;

	charger->num_supplies = ARRAY_SIZE(bq24190_charger_supplied_to);

	charger->num_supplicants = ARRAY_SIZE(bq24190_charger_supplied_to);

	charger->get_property = bq24190_charger_get_property;

	charger->get_property = bq24190_charger_get_property;

	charger->set_property = bq24190_charger_set_property;

	charger->set_property = bq24190_charger_set_property;

	charger->property_is_writeable = bq24190_charger_property_is_writeable;

	charger->property_is_writeable = bq24190_charger_property_is_writeable;