Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 46828a56 authored by H Hartley Sweeten's avatar H Hartley Sweeten Committed by Greg Kroah-Hartman
Browse files

staging: comedi: amplc_pc236: remove dev_err() message due to allocation failure 



The subdev_8255_init() call can only fail due to the allocation of the private
data. This failure will alreay have produced an error message. Remove the
redundant dev_err().

Signed-off-by: default avatarH Hartley Sweeten <hsweeten@visionengravers.com>
Reviewed-by: default avatarIan Abbott <abbotti@mev.co.uk>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e6439a45

drivers/staging/comedi/drivers/amplc_pc236.c

+2 −3
Original line number Diff line number Diff line
@@ -411,10 +411,9 @@ static int pc236_common_attach(struct comedi_device *dev, unsigned long iobase, 
	s = &dev->subdevices[0];

	/* digital i/o subdevice (8255) */

	ret = subdev_8255_init(dev, s, NULL, iobase);

	if (ret < 0) {

		dev_err(dev->class_dev, "error! out of memory!\n");

	if (ret)

		return ret;

	}



	s = &dev->subdevices[1];

	dev->read_subdev = s;

	s->type = COMEDI_SUBD_UNUSED;