Commit 450b5b18 authored Nov 01, 2005 by Stephen Hemminger Committed by Arnaldo Carvalho de Melo Nov 02, 2005

[TCP]: BIC max increment too large



The max growth of BIC TCP is too large. Original code was based on
BIC 1.0 and the default there was 32. Later code (2.6.13) included
compensation for delayed acks, and should have reduced the default
value to 16; since normally TCP gets one ack for every two packets sent.

The current value of 32 makes BIC too aggressive and unfair to other
flows.

Submitted-by: Injong Rhee <rhee@eos.ncsu.edu>
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Acked-by: Ian McDonald <imcdnzl@gmail.com>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>

parent 8713dbf0

net/ipv4/tcp_bic.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -27,7 +27,7 @@
	*/		*/

	static int fast_convergence = 1;		static int fast_convergence = 1;
	static int max_increment = 32;		static int max_increment = 16;
	static int low_window = 14;		static int low_window = 14;
	static int beta = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */		static int beta = 819; /* = 819/1024 (BICTCP_BETA_SCALE) */
	static int low_utilization_threshold = 153;		static int low_utilization_threshold = 153;