Commit 4482a44f authored Dec 30, 2013 by Casey Schaufler

Smack: File receive audit correction

Eric Paris politely points out:

    Inside smack_file_receive() it seems like you are initting the audit
    field with LSM_AUDIT_DATA_TASK.  And then use
    smk_ad_setfield_u_fs_path().

    Seems like LSM_AUDIT_DATA_PATH would make more sense.  (and depending
    on how it's used fix a crash...)

He is correct. This puts things in order.

Targeted for git://git.gitorious.org/smack-next/kernel.git



Signed-off-by: Casey Schaufler <casey@schaufler-ca.com>

parent 24ea1b6e

security/smack/smack_lsm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1351,7 +1351,7 @@ static int smack_file_receive(struct file *file)
		int may = 0;
		struct smk_audit_info ad;

		smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_TASK);
		smk_ad_init(&ad, __func__, LSM_AUDIT_DATA_PATH);
		smk_ad_setfield_u_fs_path(&ad, file->f_path);
		/*
		* This code relies on bitmasks.