Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 440b87ea authored by Paul Gortmaker's avatar Paul Gortmaker Committed by David S. Miller
Browse files

drivers/net: fix build warning in ethernet/sfc/tx.c 



Commit ee45fd92 ("sfc: Use TX PIO
for sufficiently small packets") introduced the following warning:

drivers/net/ethernet/sfc/tx.c: In function 'efx_enqueue_skb':
drivers/net/ethernet/sfc/tx.c:432:1: warning: label 'finish_packet' defined but not used

Stick the label inside the same #ifdef that the code which calls
it uses.  Note that this is only seen for arch that do not set
ARCH_HAS_IOREMAP_WC, such as arm, mips, sparc, ..., as the others
enable the write combining code and hence use the label.

Cc: Jon Cooper <jcooper@solarflare.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Signed-off-by: default avatarPaul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: default avatarShradha Shah <sshah@solarflare.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 4ccd0bb9

drivers/net/ethernet/sfc/tx.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -429,7 +429,9 @@ netdev_tx_t efx_enqueue_skb(struct efx_tx_queue *tx_queue, struct sk_buff *skb) 
	}

	}





	/* Transfer ownership of the skb to the final buffer */

	/* Transfer ownership of the skb to the final buffer */

#ifdef EFX_USE_PIO

finish_packet:

finish_packet:

#endif

	buffer->skb = skb;

	buffer->skb = skb;

	buffer->flags = EFX_TX_BUF_SKB | dma_flags;

	buffer->flags = EFX_TX_BUF_SKB | dma_flags;