Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 41e16e98 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Nicholas Bellinger
Browse files

target: remove the se_task task_error_status field 



We only reach transport_complete_task once per task, so the test and set on
task_error_status is never going to have an effect.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent ef804a84

drivers/target/target_core_transport.c

+1 −7
Original line number Diff line number Diff line
@@ -738,13 +738,7 @@ void transport_complete_task(struct se_task *task, int success) 
	}



	if (cmd->t_tasks_failed) {

		if (!task->task_error_status) {

			task->task_error_status =

				TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;

			cmd->scsi_sense_reason =

				TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;

		}



		cmd->scsi_sense_reason = TCM_LOGICAL_UNIT_COMMUNICATION_FAILURE;

		INIT_WORK(&cmd->work, target_complete_failure_work);

	} else {

		atomic_set(&cmd->t_transport_complete, 1);

include/target/target_core_base.h

+0 −1
Original line number Diff line number Diff line
@@ -490,7 +490,6 @@ struct se_task { 
	u32			task_sg_nents;

	u16			task_flags;

	u8			task_scsi_status;

	int			task_error_status;

	enum dma_data_direction	task_data_direction;

	atomic_t		task_state_active;

	struct list_head	t_list;