Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4191f197 authored by Wolfram Sang's avatar Wolfram Sang Committed by Mark Brown
Browse files

regmap: if format_write is used, declare all registers as "unreadable" 



Using .format_write means, we have a custom function to write to the
chip, but not to read back. Also, mark registers as "not precious" and
"not volatile" which is implicit because we cannot read them. Make those
functions use 'regmap_readable' to reuse the checks done there.

Signed-off-by: default avatarWolfram Sang <w.sang@pengutronix.de>
Signed-off-by: default avatarMark Brown <broonie@opensource.wolfsonmicro.com>
parent c212accc

drivers/base/regmap/regmap.c

+5 −2
Original line number Diff line number Diff line
@@ -36,6 +36,9 @@ bool regmap_readable(struct regmap *map, unsigned int reg) 
	if (map->max_register && reg > map->max_register)

		return false;



	if (map->format.format_write)

		return false;



	if (map->readable_reg)

		return map->readable_reg(map->dev, reg);
@@ -44,7 +47,7 @@ bool regmap_readable(struct regmap *map, unsigned int reg) 


bool regmap_volatile(struct regmap *map, unsigned int reg)

{

	if (map->max_register && reg > map->max_register)

	if (!regmap_readable(map, reg))

		return false;



	if (map->volatile_reg)
@@ -55,7 +58,7 @@ bool regmap_volatile(struct regmap *map, unsigned int reg) 


bool regmap_precious(struct regmap *map, unsigned int reg)

{

	if (map->max_register && reg > map->max_register)

	if (!regmap_readable(map, reg))

		return false;



	if (map->precious_reg)