Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 407ed835 authored by Axel Lin's avatar Axel Lin Committed by Kishon Vijay Abraham I
Browse files

phy: spear1340-miphy: Return proper error for spear1340_miphy_xlate 



The of_xlate callback should return ERR_PTR on error.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarKishon Vijay Abraham I <kishon@ti.com>
parent 247e21c6

drivers/phy/phy-spear1340-miphy.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -229,14 +229,14 @@ static struct phy *spear1340_miphy_xlate(struct device *dev, 




	if (args->args_count < 1) {

	if (args->args_count < 1) {

		dev_err(dev, "DT did not pass correct no of args\n");

		dev_err(dev, "DT did not pass correct no of args\n");

		return NULL;

		return ERR_PTR(-ENODEV);

	}

	}





	priv->mode = args->args[0];

	priv->mode = args->args[0];





	if (priv->mode != SATA && priv->mode != PCIE) {

	if (priv->mode != SATA && priv->mode != PCIE) {

		dev_err(dev, "DT did not pass correct phy mode\n");

		dev_err(dev, "DT did not pass correct phy mode\n");

		return NULL;

		return ERR_PTR(-ENODEV);

	}

	}





	return priv->phy;

	return priv->phy;