Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3cfc1590 authored by Devendra Naga's avatar Devendra Naga Committed by David S. Miller
Browse files

at91ether: return PTR_ERR if call to clk_get fails 



we are currently returning ENODEV, as the clk_get may give a exact
error code in its returned pointer, assign it to the ret by using the
PTR_ERR function, so that the subsequent goto label will jump to the
error path and clean the driver and return the error correctly.

Signed-off-by: default avatarDevendra Naga <devendra.aaru@gmail.com>
Acked-by: default avatarNicolas Ferre <nicolas.ferre@atmel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent e3ac104d

drivers/net/ethernet/cadence/at91_ether.c

+1 −1
Original line number Diff line number Diff line
@@ -1086,7 +1086,7 @@ static int __init at91ether_probe(struct platform_device *pdev) 
	/* Clock */

	lp->ether_clk = clk_get(&pdev->dev, "ether_clk");

	if (IS_ERR(lp->ether_clk)) {

		res = -ENODEV;

		res = PTR_ERR(lp->ether_clk);

		goto err_ioumap;

	}

	clk_enable(lp->ether_clk);