Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3c2b633b authored by Tharun Kumar Merugu's avatar Tharun Kumar Merugu Committed by Gerrit - the friendly Code Review server
Browse files

sdm660: ADSPRPC: Null check file session ctx during mmap create 



During fastrpc mmap create and mmap free, we are dereferencing
file session context without checking for Null.

Change-Id: I65fc2bb566e2e6e7914b86044e17577a96db6b4f
Acked-by: default avatarVishnu Karthik D <vikarthi@qti.qualcomm.com>
Signed-off-by: default avatarTharun Kumar Merugu <mtharu@codeaurora.org>
parent 630218f7

drivers/char/adsprpc.c

+4 −1
Original line number Diff line number Diff line
@@ -553,7 +553,7 @@ static void fastrpc_mmap_free(struct fastrpc_mmap *map) 


		if (!IS_ERR_OR_NULL(map->handle))

			ion_free(fl->apps->client, map->handle);

		if (sess->smmu.enabled) {

		if (sess && sess->smmu.enabled) {

			if (map->size || map->phys)

				msm_dma_unmap_sg(sess->smmu.dev,

					map->table->sgl,
@@ -645,6 +645,9 @@ static int fastrpc_mmap_create(struct fastrpc_file *fl, int fd, unsigned attr, 
		else

			sess = fl->sctx;



		VERIFY(err, !IS_ERR_OR_NULL(sess));

		if (err)

			goto bail;

		VERIFY(err, !IS_ERR_OR_NULL(map->buf = dma_buf_get(fd)));

		if (err)

			goto bail;