Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3b7b72ee authored by Johannes Berg's avatar Johannes Berg Committed by John W. Linville
Browse files

nl80211: clean up genlmsg_end uses 



genlmsg_end() cannot fail, it just returns the length
of the message. Thus, error handling for it is useless.
While removing it, I also noticed a useless variable
and removed this it as well.

Signed-off-by: default avatarJohannes Berg <johannes.berg@intel.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 028f78d4

net/wireless/nl80211.c

+19 −78
Original line number Diff line number Diff line
@@ -6634,10 +6634,7 @@ void nl80211_send_reg_change_event(struct regulatory_request *request) 
	if (wiphy_idx_valid(request->wiphy_idx))

		NLA_PUT_U32(msg, NL80211_ATTR_WIPHY, request->wiphy_idx);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	rcu_read_lock();

	genlmsg_multicast_allns(msg, 0, nl80211_regulatory_mcgrp.id,
@@ -6673,10 +6670,7 @@ static void nl80211_send_mlme_event(struct cfg80211_registered_device *rdev, 
	NLA_PUT_U32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex);

	NLA_PUT(msg, NL80211_ATTR_FRAME, len, buf);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -6757,10 +6751,7 @@ static void nl80211_send_mlme_timeout(struct cfg80211_registered_device *rdev, 
	NLA_PUT_FLAG(msg, NL80211_ATTR_TIMED_OUT);

	NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, addr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -6816,10 +6807,7 @@ void nl80211_send_connect_result(struct cfg80211_registered_device *rdev, 
	if (resp_ie)

		NLA_PUT(msg, NL80211_ATTR_RESP_IE, resp_ie_len, resp_ie);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -6857,10 +6845,7 @@ void nl80211_send_roamed(struct cfg80211_registered_device *rdev, 
	if (resp_ie)

		NLA_PUT(msg, NL80211_ATTR_RESP_IE, resp_ie_len, resp_ie);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -6898,10 +6883,7 @@ void nl80211_send_disconnected(struct cfg80211_registered_device *rdev, 
	if (ie)

		NLA_PUT(msg, NL80211_ATTR_IE, ie_len, ie);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, GFP_KERNEL);
@@ -6934,10 +6916,7 @@ void nl80211_send_ibss_bssid(struct cfg80211_registered_device *rdev, 
	NLA_PUT_U32(msg, NL80211_ATTR_IFINDEX, netdev->ifindex);

	NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, bssid);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -6972,10 +6951,7 @@ void nl80211_send_new_peer_candidate(struct cfg80211_registered_device *rdev, 
	if (ie_len && ie)

		NLA_PUT(msg, NL80211_ATTR_IE, ie_len , ie);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7014,10 +6990,7 @@ void nl80211_michael_mic_failure(struct cfg80211_registered_device *rdev, 
	if (tsc)

		NLA_PUT(msg, NL80211_ATTR_KEY_SEQ, 6, tsc);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7068,10 +7041,7 @@ void nl80211_send_beacon_hint_event(struct wiphy *wiphy, 
		goto nla_put_failure;

	nla_nest_end(msg, nl_freq);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	rcu_read_lock();

	genlmsg_multicast_allns(msg, 0, nl80211_regulatory_mcgrp.id,
@@ -7114,10 +7084,7 @@ static void nl80211_send_remain_on_chan_event( 
	if (cmd == NL80211_CMD_REMAIN_ON_CHANNEL)

		NLA_PUT_U32(msg, NL80211_ATTR_DURATION, duration);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7188,10 +7155,7 @@ void nl80211_send_sta_del_event(struct cfg80211_registered_device *rdev, 
	NLA_PUT_U32(msg, NL80211_ATTR_IFINDEX, dev->ifindex);

	NLA_PUT(msg, NL80211_ATTR_MAC, ETH_ALEN, mac_addr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7208,7 +7172,6 @@ int nl80211_send_mgmt(struct cfg80211_registered_device *rdev, 
{

	struct sk_buff *msg;

	void *hdr;

	int err;



	msg = nlmsg_new(NLMSG_DEFAULT_SIZE, gfp);

	if (!msg)
@@ -7225,16 +7188,9 @@ int nl80211_send_mgmt(struct cfg80211_registered_device *rdev, 
	NLA_PUT_U32(msg, NL80211_ATTR_WIPHY_FREQ, freq);

	NLA_PUT(msg, NL80211_ATTR_FRAME, len, buf);



	err = genlmsg_end(msg, hdr);

	if (err < 0) {

		nlmsg_free(msg);

		return err;

	}

	genlmsg_end(msg, hdr);



	err = genlmsg_unicast(wiphy_net(&rdev->wiphy), msg, nlpid);

	if (err < 0)

		return err;

	return 0;

	return genlmsg_unicast(wiphy_net(&rdev->wiphy), msg, nlpid);



 nla_put_failure:

	genlmsg_cancel(msg, hdr);
@@ -7267,10 +7223,7 @@ void nl80211_send_mgmt_tx_status(struct cfg80211_registered_device *rdev, 
	if (ack)

		NLA_PUT_FLAG(msg, NL80211_ATTR_ACK);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast(msg, 0, nl80211_mlme_mcgrp.id, gfp);

	return;
@@ -7312,10 +7265,7 @@ nl80211_send_cqm_rssi_notify(struct cfg80211_registered_device *rdev, 


	nla_nest_end(msg, pinfoattr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7357,10 +7307,7 @@ void nl80211_gtk_rekey_notify(struct cfg80211_registered_device *rdev, 


	nla_nest_end(msg, rekey_attr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7403,10 +7350,7 @@ void nl80211_pmksa_candidate_notify(struct cfg80211_registered_device *rdev, 


	nla_nest_end(msg, attr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);
@@ -7448,10 +7392,7 @@ nl80211_send_cqm_pktloss_notify(struct cfg80211_registered_device *rdev, 


	nla_nest_end(msg, pinfoattr);



	if (genlmsg_end(msg, hdr) < 0) {

		nlmsg_free(msg);

		return;

	}

	genlmsg_end(msg, hdr);



	genlmsg_multicast_netns(wiphy_net(&rdev->wiphy), msg, 0,

				nl80211_mlme_mcgrp.id, gfp);