Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 399db75b authored by Fabio Estevam's avatar Fabio Estevam Committed by David S. Miller
Browse files

fec: Remove unneeded check in platform_get_resource() 



As devm_ioremap_resource() is used, there is no need to explicitely check the
return value from platform_get_resource(), as this is something that
devm_ioremap_resource() takes care by itself.

Also, place platform_get_resource() prior to devm_ioremap_resource() for
better code readability.

Signed-off-by: default avatarFabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 13a097bd

drivers/net/ethernet/freescale/fec_main.c

+1 −4
Original line number Original line Diff line number Diff line
@@ -2033,10 +2033,6 @@ fec_probe(struct platform_device *pdev) 
	if (of_id)

	if (of_id)

		pdev->id_entry = of_id->data;

		pdev->id_entry = of_id->data;





	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	if (!r)

		return -ENXIO;



	/* Init network device */

	/* Init network device */

	ndev = alloc_etherdev(sizeof(struct fec_enet_private));

	ndev = alloc_etherdev(sizeof(struct fec_enet_private));

	if (!ndev)

	if (!ndev)
@@ -2054,6 +2050,7 @@ fec_probe(struct platform_device *pdev) 
		fep->pause_flag |= FEC_PAUSE_FLAG_AUTONEG;

		fep->pause_flag |= FEC_PAUSE_FLAG_AUTONEG;

#endif

#endif





	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);

	fep->hwp = devm_ioremap_resource(&pdev->dev, r);

	fep->hwp = devm_ioremap_resource(&pdev->dev, r);

	if (IS_ERR(fep->hwp)) {

	if (IS_ERR(fep->hwp)) {

		ret = PTR_ERR(fep->hwp);

		ret = PTR_ERR(fep->hwp);