Commit 397488e0 authored Jul 06, 2016 by Vitaly Kuznetsov Committed by Greg Kroah-Hartman Apr 27, 2017

Tools: hv: kvp: ensure kvp device fd is closed on exec



commit 26840437cbd6d3625ea6ab34e17cd34bb810c861 upstream.

KVP daemon does fork()/exec() (with popen()) so we need to close our fds
to avoid sharing them with child processes. The immediate implication of
not doing so I see is SELinux complaining about 'ip' trying to access
'/dev/vmbus/hv_kvp'.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Sumit Semwal <sumit.semwal@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 2a60bb63

tools/hv/hv_kvp_daemon.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1433,7 +1433,7 @@ int main(int argc, char *argv[])
		openlog("KVP", 0, LOG_USER);
		syslog(LOG_INFO, "KVP starting; pid is:%d", getpid());

		kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR);
		kvp_fd = open("/dev/vmbus/hv_kvp", O_RDWR \| O_CLOEXEC);

		if (kvp_fd < 0) {
		syslog(LOG_ERR, "open /dev/vmbus/hv_kvp failed; error: %d %s",