Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 390bddc4 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Greg Kroah-Hartman
Browse files

hwrng: exynos - Disable runtime PM on probe failure 



commit 48a61e1e2af8020f11a2b8f8dc878144477623c6 upstream.

Add proper error path (for disabling runtime PM) when registering of
hwrng fails.

Fixes: b329669e ("hwrng: exynos - Add support for Exynos random number generator")
Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aaac8cab

drivers/char/hw_random/exynos-rng.c

+8 −1
Original line number Diff line number Diff line
@@ -118,6 +118,7 @@ static int exynos_rng_probe(struct platform_device *pdev) 
{

	struct exynos_rng *exynos_rng;

	struct resource *res;

	int ret;



	exynos_rng = devm_kzalloc(&pdev->dev, sizeof(struct exynos_rng),

					GFP_KERNEL);
@@ -145,7 +146,13 @@ static int exynos_rng_probe(struct platform_device *pdev) 
	pm_runtime_use_autosuspend(&pdev->dev);

	pm_runtime_enable(&pdev->dev);



	return devm_hwrng_register(&pdev->dev, &exynos_rng->rng);

	ret = devm_hwrng_register(&pdev->dev, &exynos_rng->rng);

	if (ret) {

		pm_runtime_dont_use_autosuspend(&pdev->dev);

		pm_runtime_disable(&pdev->dev);

	}



	return ret;

}



#ifdef CONFIG_PM