Commit 38def50f authored May 01, 2008 by Fred Isaman Committed by Trond Myklebust May 16, 2008

nfs: fix race in nfs_dirty_request



When called from nfs_flush_incompatible, the req is not locked, so
req->wb_page might be set to NULL before it is used by PageWriteback.

Signed-off-by: Fred Isaman <iisaman@citi.umich.edu>
Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

parent b0b53973

fs/nfs/write.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -415,7 +415,7 @@ nfs_dirty_request(struct nfs_page *req)

	if (page == NULL \|\| test_bit(PG_NEED_COMMIT, &req->wb_flags))		if (page == NULL \|\| test_bit(PG_NEED_COMMIT, &req->wb_flags))
	return 0;		return 0;
	return !PageWriteback(req->wb_page);		return !PageWriteback(page);
	}		}

	#if defined(CONFIG_NFS_V3) \|\| defined(CONFIG_NFS_V4)		#if defined(CONFIG_NFS_V3) \|\| defined(CONFIG_NFS_V4)