Commit 369dacc3 authored Mar 17, 2020 by Alexander Shishkin Committed by Greg Kroah-Hartman Apr 02, 2020

intel_th: Fix user-visible error codes



commit ce666be89a8a09c5924ff08fc32e119f974bdab6 upstream.

There are a few places in the driver that end up returning ENOTSUPP to
the user, replace those with EINVAL.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Fixes: ba82664c ("intel_th: Add Memory Storage Unit driver")
Cc: stable@vger.kernel.org # v4.4+
Link: https://lore.kernel.org/r/20200317062215.15598-6-alexander.shishkin@linux.intel.com


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 9ddb6c7b

drivers/hwtracing/intel_th/msu.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -483,7 +483,7 @@ static int msc_configure(struct msc *msc)
		u32 reg;

		if (msc->mode > MSC_MODE_MULTI)
		return -ENOTSUPP;
		return -EINVAL;

		if (msc->mode == MSC_MODE_MULTI)
		msc_buffer_clear_hw_header(msc);
		@@ -935,7 +935,7 @@ static int msc_buffer_alloc(struct msc msc, unsigned long nr_pages,
		} else if (msc->mode == MSC_MODE_MULTI) {
		ret = msc_buffer_multi_alloc(msc, nr_pages, nr_wins);
		} else {
		ret = -ENOTSUPP;
		ret = -EINVAL;
		}

		if (!ret) {
		@@ -1164,7 +1164,7 @@ static ssize_t intel_th_msc_read(struct file file, char __user buf,
		if (ret >= 0)
		*ppos = iter->offset;
		} else {
		ret = -ENOTSUPP;
		ret = -EINVAL;
		}

		put_count: