Commit 35717130 authored May 27, 2020 by Alexander Potapenko Committed by Gerrit - the friendly Code Review server Feb 26, 2021

fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()



KMSAN reported uninitialized data being written to disk when dumping
core.  As a result, several kilobytes of kmalloc memory may be written
to the core file and then read by a non-privileged user.

Reported-by: sam <sunhaoyl@outlook.com>
Signed-off-by: Alexander Potapenko <glider@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Kees Cook <keescook@chromium.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/20200419100848.63472-1-glider@google.com
Link: https://github.com/google/kmsan/issues/76


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Change-Id: I520891209b7c6668ed8595fee508d63c6f12827b
Git-commit: 1d605416fb7175e1adf094251466caa52093b413
Git-repo: https://android.googlesource.com/kernel/msm


Signed-off-by: urevanth <urevanth@codeaurora.org>

parent 66b4b5d5

fs/binfmt_elf.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1718,7 +1718,7 @@ static int fill_thread_core_info(struct elf_thread_core_info *t,
		(!regset->active \|\| regset->active(t->task, regset) > 0)) {
		int ret;
		size_t size = regset->n * regset->size;
		void *data = kmalloc(size, GFP_KERNEL);
		void *data = kzalloc(size, GFP_KERNEL);
		if (unlikely(!data))
		return 0;
		ret = regset->get(t->task, regset,